From 607148d299186607ebd3dd0283a80767f20249c1 Mon Sep 17 00:00:00 2001 From: "Daniel (dB.) Doubrovkine" Date: Mon, 5 Jan 2026 14:42:12 -0500 Subject: [PATCH] Migrate Danger to use danger-pr-comment workflow. --- .github/workflows/danger-comment.yml | 11 +++++++++++ .github/workflows/danger.yml | 28 +++++++++++----------------- .github/workflows/rubocop.yml | 2 +- .github/workflows/test.yml | 2 +- CHANGELOG.md | 1 + Dangerfile | 4 +++- Gemfile | 4 ++++ Gemfile.danger | 6 ------ 8 files changed, 32 insertions(+), 26 deletions(-) create mode 100644 .github/workflows/danger-comment.yml delete mode 100644 Gemfile.danger diff --git a/.github/workflows/danger-comment.yml b/.github/workflows/danger-comment.yml new file mode 100644 index 0000000..8e15cb6 --- /dev/null +++ b/.github/workflows/danger-comment.yml @@ -0,0 +1,11 @@ +name: Danger Comment + +on: + workflow_run: + workflows: [Danger] + types: [completed] + +jobs: + comment: + uses: numbata/danger-pr-comment/.github/workflows/danger-comment.yml@v0.1.0 + secrets: inherit diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index b2ba0a4..bd89a88 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,19 +1,13 @@ -name: PR Linter -on: [pull_request] +name: Danger + +on: + pull_request: + types: [opened, reopened, edited, synchronize] + jobs: danger: - runs-on: ubuntu-latest - env: - BUNDLE_GEMFILE: ${{ github.workspace }}/Gemfile.danger - steps: - - uses: actions/checkout@v2 - with: - fetch-depth: 0 - - uses: ruby/setup-ruby@v1 - with: - ruby-version: 3.3.6 - bundler-cache: true - - run: | - # the personal token is public, this is ok, base64 encode to avoid tripping Github - TOKEN=$(echo -n Z2hwX0xNQ3VmanBFeTBvYkZVTWh6NVNqVFFBOEUxU25abzBqRUVuaAo= | base64 --decode) - DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose + uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0 + secrets: inherit + with: + ruby-version: '3.4' + bundler-cache: true diff --git a/.github/workflows/rubocop.yml b/.github/workflows/rubocop.yml index b13af56..665d1aa 100644 --- a/.github/workflows/rubocop.yml +++ b/.github/workflows/rubocop.yml @@ -8,6 +8,6 @@ jobs: - name: Set up Ruby uses: ruby/setup-ruby@v1 with: - ruby-version: 3.3.6 + ruby-version: 3.4.1 bundler-cache: true - run: bundle exec rubocop diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4d422ae..0358f29 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -6,7 +6,7 @@ jobs: strategy: matrix: ruby-version: - - 3.3.6 + - 3.4.1 steps: - uses: actions/checkout@v3 - name: Set up Ruby diff --git a/CHANGELOG.md b/CHANGELOG.md index 776fa0f..be31f80 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ ### 0.6.0 (Next) +* [#38](https://github.com/dblock/fue/pull/38): Migrate Danger to use danger-pr-comment workflow - [@dblock](https://github.com/dblock). * [#37](https://github.com/dblock/fue/pull/36): Added fetching of e-mails from `Signed-off-by` and `--[no-]signed-off-by` - [@dblock](https://github.com/dblock). * [#36](https://github.com/dblock/fue/pull/36): Added `--[no-]reply` to exclude `@users.noreply.github.com` email addresses - [@dblock](https://github.com/dblock). * Your contribution here. diff --git a/Dangerfile b/Dangerfile index f6ebfe5..b4bc366 100644 --- a/Dangerfile +++ b/Dangerfile @@ -1,4 +1,6 @@ # frozen_string_literal: true -toc.check! +danger.import_dangerfile(gem: 'danger-pr-comment') + changelog.check! +toc.check! diff --git a/Gemfile b/Gemfile index b80bcd4..644a44b 100644 --- a/Gemfile +++ b/Gemfile @@ -5,6 +5,10 @@ source 'http://rubygems.org' gemspec group :development, :test do + gem 'danger', require: false + gem 'danger-changelog', require: false + gem 'danger-pr-comment', require: false + gem 'danger-toc', require: false gem 'rake' gem 'recursive-open-struct' gem 'rspec' diff --git a/Gemfile.danger b/Gemfile.danger deleted file mode 100644 index 0a8f507..0000000 --- a/Gemfile.danger +++ /dev/null @@ -1,6 +0,0 @@ -source 'https://rubygems.org' - -group :test do - gem 'danger-changelog', '~> 0.6.1' - gem 'danger-toc', '~> 0.2.0', require: false -end