-
Notifications
You must be signed in to change notification settings - Fork 7
Split timezone into two lines #48
Copy link
Copy link
Open
Labels
[priority] lowLow-priority issuesLow-priority issues[tech] javascriptResolution is likely to involve JavaScriptResolution is likely to involve JavaScript[tech] meteorjsResolution is likely to require basic understanding of MeteorJSResolution is likely to require basic understanding of MeteorJS[tech] reactResolution is likely to involve ReactJSResolution is likely to involve ReactJS
Milestone
Metadata
Metadata
Assignees
Labels
[priority] lowLow-priority issuesLow-priority issues[tech] javascriptResolution is likely to involve JavaScriptResolution is likely to involve JavaScript[tech] meteorjsResolution is likely to require basic understanding of MeteorJSResolution is likely to require basic understanding of MeteorJS[tech] reactResolution is likely to involve ReactJSResolution is likely to involve ReactJS
Current issue is that our timezone can sometimes be too long to fit inside a MatchCard component.

Proposing to breakdown the timezone into two segments so that they can be rendered as:

One approach would be to splice the
timezonevalue and splitting them in the MatchCard component.cb-connect/imports/ui/components/dashboard/match_card.jsx
Line 35 in c8d179b
For example, if
timezonereturns the value ofuse JS to split at
)(or use regex to split the value from(...)and everything else) so that we can add a break in between in the MatchCard render function:where
timezoneis now an array of['(GMT-12:00)', 'International Date Line West']--
A second approach would be to refactor the entries file so that the timezones are already split accordingly: