From f161d7d3b29dc3f37ef9fe4ec60501e4d1f69034 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Fri, 20 Mar 2026 17:35:29 -0700 Subject: [PATCH] Add objc_fully_link to linker_param_file This action goes through the same linking logic as c++-link-static-library so it also gets this variable --- cc/toolchains/args/linker_param_file/BUILD | 1 + cc/toolchains/variables/BUILD | 1 + .../goldens/unix/linker_param_file.textproto | 1 + 3 files changed, 3 insertions(+) diff --git a/cc/toolchains/args/linker_param_file/BUILD b/cc/toolchains/args/linker_param_file/BUILD index b9d4096df..efdc3edc8 100644 --- a/cc/toolchains/args/linker_param_file/BUILD +++ b/cc/toolchains/args/linker_param_file/BUILD @@ -22,6 +22,7 @@ cc_args( actions = [ "//cc/toolchains/actions:link_actions", "//cc/toolchains/actions:ar_actions", + "//cc/toolchains/actions:objc_fully_link", ], args = ["@{param_file}"], format = {"param_file": "//cc/toolchains/variables:linker_param_file"}, diff --git a/cc/toolchains/variables/BUILD b/cc/toolchains/variables/BUILD index 9951929b1..c21c9b5f6 100644 --- a/cc/toolchains/variables/BUILD +++ b/cc/toolchains/variables/BUILD @@ -269,6 +269,7 @@ cc_variable( name = "linker_param_file", actions = [ "//cc/toolchains/actions:cpp_link_static_library", + "//cc/toolchains/actions:objc_fully_link", "//cc/toolchains/actions:link_actions", ], type = types.option(types.file), diff --git a/tests/rule_based_toolchain/legacy_features_as_args/goldens/unix/linker_param_file.textproto b/tests/rule_based_toolchain/legacy_features_as_args/goldens/unix/linker_param_file.textproto index 84a71e031..3f99c7420 100644 --- a/tests/rule_based_toolchain/legacy_features_as_args/goldens/unix/linker_param_file.textproto +++ b/tests/rule_based_toolchain/legacy_features_as_args/goldens/unix/linker_param_file.textproto @@ -8,6 +8,7 @@ flag_sets { actions: "lto-index-for-executable" actions: "lto-index-for-nodeps-dynamic-library" actions: "objc-executable" + actions: "objc-fully-link" flag_groups { expand_if_available: "linker_param_file" flags: "@%{linker_param_file}"