From 50bdc9b3355a1a37841fa50658fd51470152f65c Mon Sep 17 00:00:00 2001 From: Austin Schuh Date: Wed, 29 Jan 2025 20:34:38 -0800 Subject: [PATCH] Add more actions needed to build fully features rule toolchains Digging through which tools toolchains_llvm uses, we need more actions to be able to use all the features. Signed-off-by: Austin Schuh --- cc/action_names.bzl | 10 ++++++++++ cc/toolchains/actions/BUILD | 25 +++++++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/cc/action_names.bzl b/cc/action_names.bzl index 31a596718..73c1f586d 100644 --- a/cc/action_names.bzl +++ b/cc/action_names.bzl @@ -49,7 +49,12 @@ ASSEMBLE_ACTION_NAME = "assemble" # Name of the assembly preprocessing action. PREPROCESS_ASSEMBLE_ACTION_NAME = "preprocess-assemble" +DWP = "dwp" +GCOV = "gcov" LLVM_COV = "llvm-cov" +LLVM_PROFDATA = "llvm-profdata" +NM = "nm" +OBJDUMP = "objdump" # Name of the action producing ThinLto index. LTO_INDEXING_ACTION_NAME = "lto-indexing" @@ -116,7 +121,12 @@ ACTION_NAMES = struct( cpp_module_compile = CPP_MODULE_COMPILE_ACTION_NAME, assemble = ASSEMBLE_ACTION_NAME, preprocess_assemble = PREPROCESS_ASSEMBLE_ACTION_NAME, + dwp = DWP, + gcov = GCOV, llvm_cov = LLVM_COV, + llvm_profdata = LLVM_PROFDATA, + nm = NM, + objdump = OBJDUMP, lto_indexing = LTO_INDEXING_ACTION_NAME, lto_backend = LTO_BACKEND_ACTION_NAME, lto_index_for_executable = LTO_INDEX_FOR_EXECUTABLE_ACTION_NAME, diff --git a/cc/toolchains/actions/BUILD b/cc/toolchains/actions/BUILD index 9eb0ce742..3078ba2bd 100644 --- a/cc/toolchains/actions/BUILD +++ b/cc/toolchains/actions/BUILD @@ -148,6 +148,31 @@ cc_action_type( action_name = ACTION_NAMES.validate_static_library, ) +cc_action_type( + name = "dwp", + action_name = ACTION_NAMES.dwp, +) + +cc_action_type( + name = "gcov", + action_name = ACTION_NAMES.gcov, +) + +cc_action_type( + name = "llvm_profdata", + action_name = ACTION_NAMES.llvm_profdata, +) + +cc_action_type( + name = "nm", + action_name = ACTION_NAMES.nm, +) + +cc_action_type( + name = "objdump", + action_name = ACTION_NAMES.objdump, +) + # ld_embed_data is only available within google. cc_action_type( # # copybara-comment-this-out-please