-
Notifications
You must be signed in to change notification settings - Fork 3
Playground / API: Better ThemeWarnings / Feedback #29
Copy link
Copy link
Open
Description
Currently for feedback, we:
- Return an
IndexSet<String>. - Only return feedback for stroke/outline/fill CSS class partials that don't result in an actual tailwind CSS class being generated.
Improvements that we can do (perhaps do these one at a time) are:
-
Proper typed errors instead of
Strings, e.g. enum with a variant for each error. -
Validate keys that aren't used:
Keep a
Map<ThemeAttr, UsedOrNot>, and mark it as used as each node/edge's CSS classes are computed.At the end, find unused
ThemeAttrkeys, and report these back to the user.Bonus points if we know the src location, but that generally means not losing it during deserialization. See [
saphyr#] -
Parse values for each key -- or instead of using
Map<ThemeAttr, String>, we actually have a proper type.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels