Skip to content

Typo in SE_GSM prevents likely product nodes from being optimized #68

@b3m2a1

Description

@b3m2a1

This line was clearly intended to reference "SE_GSM" not "SE-GSM" (although should have been implemented with isinstance or explicitly on the subclass):

if self.__class__.__name__ == "SE-GSM" and self.done_growing:

        if self.__class__.__name__ == "SE-GSM" and self.done_growing:
            fp = self.find_peaks('opting')
            if self.energies[self.nnodes-1] > self.energies[self.nnodes-2] and fp > 0 and self.nodes[self.nnodes-1].gradrms > self.CONV_TOL:
                printcool('Last node is not a minimum, Might need to verify that the last node is a minimum')

This may lead the final node in SE_GSM runs to not be optimized appropriately

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions