Broken PHPUnit tests

[keesiemeijer]

Before commit e482b28 the PHPUnit tests used to work with PHPUnit 4. Now I get this error for half of the unit tests.

1) WP_Parser\Tests\Export_Docblocks::test_linebreaks_removed
Undefined property: PhpParser\Node\Stmt\Function_::$uses

/app/public/wp-content/plugins/phpdoc-parser/lib/class-file-reflector.php:174
/app/public/wp-content/plugins/phpdoc-parser/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:133
/app/public/wp-content/plugins/phpdoc-parser/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:64
/app/public/wp-content/plugins/phpdoc-parser/vendor/phpdocumentor/reflection/src/phpDocumentor/Reflection/Traverser.php:52
/app/public/wp-content/plugins/phpdoc-parser/vendor/phpdocumentor/reflection/src/phpDocumentor/Reflection/FileReflector.php:163
/app/public/wp-content/plugins/phpdoc-parser/lib/runner.php:56
/app/public/wp-content/plugins/phpdoc-parser/tests/phpunit/includes/export-testcase.php:31
/app/public/wp-content/plugins/phpdoc-parser/tests/phpunit/includes/export-testcase.php:44

[keesiemeijer]

It seems that parsed empty functions (that have no uses) are the cause of this change.

Example
https://github.com/WordPress/phpdoc-parser/blob/master/tests/phpunit/tests/export/namespace.inc#L5

[keesiemeijer]

We should check if a function has uses here
https://github.com/WordPress/phpdoc-parser/blob/master/lib/class-file-reflector.php#L174

something like this

$function = array_pop( $this->location );
if( isset( $function->uses ) && ! empty( $function->uses ) ) {
	end( $this->functions )->uses = $function->uses;
}

Because phpdocumentor/reflection 3 now uses nikic/php-parser 1 as a dependency we should also use the namespaced names as mentioned here
https://github.com/nikic/PHP-Parser/blob/master/UPGRADE-1.0.md

[maheshwaghmare]

I'm also getting same error:

Undefined property: PhpParser\Node\Stmt\Function_::$uses in ..
Undefined property: PhpParser\Node\Expr\BinaryOp\Concat::$value ..

[dmsnell]

Not sure if this is still a problem, but I found that this project is sensitive to which version of PHP created the composer.lock file.

That is, if I generate it like so, with PHP 8.5, it will install dependencies, but then I am unable to successfully parse the Core source code.

composer install --no-security-blocking

Instead, I need to currently run PHP 7.4 like so…

rm composer.lock
php74 /path/to/composer.phar install --no-security-blocking

Inside an OCI container or any setup with the global PHP version at 7.4 this shouldn’t matter, but it may be worth trying out if anyone is still watching and wants to confirm that this is still a problem. It may also be solved by #250