From c512f71b2085552b3d7258f96b54012eff7c7c2e Mon Sep 17 00:00:00 2001 From: David Avila <8167941+davilag@users.noreply.github.com> Date: Thu, 2 Apr 2026 11:17:23 +0100 Subject: [PATCH 1/2] Return not found errors --- internal/repository/memory.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/internal/repository/memory.go b/internal/repository/memory.go index 69c4cdf..096c00d 100644 --- a/internal/repository/memory.go +++ b/internal/repository/memory.go @@ -4,10 +4,13 @@ import ( "fmt" "sync" "time" + "errors" "github.com/wise/backend-interview-kit/internal/model" ) +var ErrNotFound = errors.New("item not found") + type memoryRepository struct { mu sync.RWMutex jobs map[string]*model.Job @@ -134,7 +137,7 @@ func (r *memoryRepository) GetJob(id string) (*model.Job, error) { job, ok := r.jobs[id] if !ok { - return nil, nil + return nil, ErrNotFound } return job, nil } @@ -175,7 +178,7 @@ func (r *memoryRepository) GetDriver(id string) (*model.Driver, error) { driver, ok := r.drivers[id] if !ok { - return nil, nil + return nil, ErrNotFound } return driver, nil } @@ -197,7 +200,7 @@ func (r *memoryRepository) GetDepot(id string) (*model.Depot, error) { depot, ok := r.depots[id] if !ok { - return nil, nil + return nil, ErrNotFound } return depot, nil } From b7cffe4c562f22c9e0d76ec8d08232f74176b846 Mon Sep 17 00:00:00 2001 From: David Avila <8167941+davilag@users.noreply.github.com> Date: Thu, 2 Apr 2026 13:05:52 +0100 Subject: [PATCH 2/2] Reordering errors --- internal/repository/memory.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/repository/memory.go b/internal/repository/memory.go index 096c00d..f47c7a6 100644 --- a/internal/repository/memory.go +++ b/internal/repository/memory.go @@ -1,10 +1,10 @@ package repository import ( + "errors" "fmt" "sync" "time" - "errors" "github.com/wise/backend-interview-kit/internal/model" )