Bitpacking in lib/source/pl/lib/std/time.cpp (to_local, to_utc) doesn't correctly handle big endian pragma

[applmak]

#pragma endian big
std::time::EpochTime epoch = std::time::epoch();
std::time::Time t = std::time::to_utc(epoch);
std::print("{}, {}", epoch, t);

Prints "Invalid", because the bitpacking here doesn't take endianness into account correctly.

[applmak]

Or, more specifically, the unpacking in the pattern doesn't handle this correctly.

[paxcut]

The example code you posted does not use unpacking, so I am assuming both packing and unpacking need to handle endianess. I made some tentative changes to both functions that seem to work for calls that use either one. I will add them to and upcoming PR soon after testing them a bit.

[applmak]

Sorry, I meant "packing" as in the packing of the struct tm into the uint128_t and the pattern which reverses this process.

[paxcut]

Just to clarify, I thought you were referring to the functions packTMValue and unpackTMValue that are listed in the code you posted a link for. The function to_utc uses the former and function to_local uses the later. Both need to take endianess into account so that the answers remain the same regardless of what the pragma endian is set to. Just changing the endianness of the u128 value is not enough though because two of the packed values are 16 bits so they need adjusting too.