Extra URL escaping in Firefox

[andreacampi]

Replacing attributes in a URL with {{$ $}} is broken on Firefox (tested with Mac Firefox 13.0.1).
This results in the URL being passed through unchanged.

See for example examples/template-currentdocument/index.html
In this case, when I click to post on Twitter I get: Check out {{$title$}} at {{$url$}}"

Following with Firebug, it looks like innerHTML has started escaping the href attribute, at least in some case.

There is a bug open at https://bugzilla.mozilla.org/show_bug.cgi?id=664398 with no activity in the past year.

[andreacampi]

This is not so much a bug in Treesaver as in Firefox, but it breaks social sharing buttons in Firefox so we must find a workaround.

[andreacampi]

The workaround is to use data-href; it is copied through to href automatically, and Firefox doesn't exhibit the bug there.

[bramstein]

So the problem is that when we use innerHTML to read a template one or more of {{$...$}} gets escaped by Firefox. This then result in Mustache.js not recognizing it?

[andreacampi]

Yes, exactly.

[bramstein]

Right:

>>> var a = document.createElement('div');
undefined
>>> a.innerHTML = '<a href="{{$something$}}">test</a>';
"<a href="{{$something$}}">test</a>"
>>> a.innerHTML
"<a href="%7B%7B$something$%7D%7D">test</a>"

I think that was exactly why we introduced the data-* attributes. I guess it should be documented better though.

[andreacampi]

Yeah, and most of all, the examples should be updated.