Stuck follower in followerslots

[GladieUO]

There is situation, where player loses its pet, but the follower and its index stays stuck in the slots.

So far Ive been able to find one case where this happens.

1. Pet A starts attacking pet B
2. Pet B deserts from the owner
3. Pet B is no longer my pet, however I still have him in followerslots

case2
Also consider that I have activated flag for pet not deserting if attacked by owner

1. owner cast aoe spell
2. pet gets hit by the spell
3. pet deserts, but the followerslot stays

[GladieUO]

Im suspecting it might have something to do with the flags bug, because there is no way that PET could desert. The trigger @PetDesert im returning completely. Im allowing release only when the FOOD is 0, and yet still, the pets randomly decide to desert after owner hits them, or attacks them or unknown.

They always desert, and attack its owner, which does only the part of code when they desert by being harmed by owner, and sphere flag COMBAT_NOPETDESERT being disabled. Which I have activated. And then they got stuck in followerslots.

void CChar::OnHarmedBy( CChar * pCharSrc )
{
	ADDTOCALLSTACK("CChar::OnHarmedBy");

	bool fFightActive = Fight_IsActive();
	Memory_AddObjTypes(pCharSrc, MEMORY_HARMEDBY);
	if ( m_pNPC)
	{
		if (Skill_GetActive() == NPCACT_RIDDEN) //prevent action 111 to be changed.
			return;
	}
	if (fFightActive && m_Fight_Targ_UID.CharFind())
	{
		// In war mode already
		if ( m_pPlayer )
			return;
		if ( g_Rand.Get16ValFast( 10 ))
			return;
		// NPC will Change targets.
	}

	if (!IsSetCombatFlags(COMBAT_NOPETDESERT) && m_pNPC && NPC_IsOwnedBy(pCharSrc, false))
		NPC_PetDesert();

	// I will Auto-Defend myself.
	Fight_Attack(pCharSrc);
}

[GladieUO]

New observation.

1. pets go fight
2. you hit them by physical dmg or magic dmg as OWNER
3. after they finish fighting their target, then they switch to guarding you / following you -> and after few seconds, suddenly mine memory flags on them gets overriden / removed and keeps only the memory_harmedby (me), memory_irriatedby (me) etc... memory_ipet is removed.

[mtwango]

New observation.

1. pets go fight

2. you hit them by physical dmg or magic dmg as OWNER

3. after they finish fighting their target, then they switch to guarding you / following you -> and after few seconds, suddenly mine memory flags on them gets overriden / removed and keeps only the memory_harmedby (me), memory_irriatedby (me) etc... memory_ipet is removed.

This should now be fixed on dev (#1559)

[GladieUO]

I need to test it, but I dont think it will fix the issue.
the problem was here
#1497

[mtwango]

There was an issue with removing combat memory, which could sometimes be wrong in fight_cancel