-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
the build configuration obviously uses boolean values, e.g.
Lines 24 to 25 in 35138a0
| # use python with pymalloc (look for "pythonX.Ym" files) | |
| PY_USE_PYMALLOC=1 |
however, the build system does not check whether these values are set to a true value (that is: 1), but instead it is only important that the variable is assigned any value:
Line 1 in 35138a0
| ifdef PY_USE_PYMALLOC |
the consequence is that e.g. setting PY_USE_PYMALLOC=0 will still enable pymalloc, even though the declaration suggests otherwise.
I suggest to either
- check whether a configuration variable is both defined and has a value of
1(very much preferred) - or document that the actual value does not matter
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels