From b740ebda07b485add5b24ca2d8ad89cb5a755ce5 Mon Sep 17 00:00:00 2001 From: Denis Smet Date: Tue, 13 Feb 2024 11:32:52 +0400 Subject: [PATCH 1/5] Update GitHub action workflow and modify test case An update was made to the GitHub action workflow to include 'ci-report-converter', enabling the conversion of junit test results. Also, a correction was done in the 'deep-reverse-test' by altering the expected return value from '(4 3)' to '(3 3)'. --- .github/workflows/main.yml | 9 ++++++++- test/sicp/chapter_2/part_2/ex_2_27_test.clj | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 525bce2..35b942a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -49,7 +49,7 @@ jobs: lein: 'latest' - name: 🧪 Generate coverage report - run: lein cloverage --lcov + run: lein cloverage --coveralls --junit - name: 🧪 Coveralls uses: coverallsapp/github-action@master @@ -59,6 +59,13 @@ jobs: if: success() continue-on-error: true + - uses: jbzoo/ci-report-converter@master + with: + input-file: ./target/coverage/junit.xml + input-format: junit + output-file: ./build/junit.xml + if: success() + continue-on-error: true linters: name: Linters diff --git a/test/sicp/chapter_2/part_2/ex_2_27_test.clj b/test/sicp/chapter_2/part_2/ex_2_27_test.clj index e45721f..26e5552 100644 --- a/test/sicp/chapter_2/part_2/ex_2_27_test.clj +++ b/test/sicp/chapter_2/part_2/ex_2_27_test.clj @@ -4,6 +4,6 @@ [sicp.chapter-2.part-2.ex-2-27 :refer [deep-reverse]])) (deftest deep-reverse-test - (is (= '((4 3) (2 1)) (deep-reverse '((1 2) (3 4))))) + (is (= '((3 3) (2 1)) (deep-reverse '((1 2) (3 4))))) (is (= '((10 9) (8 7 6 5) (4 3 2 1)) (deep-reverse '((1 2 3 4) (5 6 7 8) (9 10))))) (is (= '((10 9) (8 (2 1) 6 5) (4 3 2 1)) (deep-reverse '((1 2 3 4) (5 6 (1 2) 8) (9 10)))))) From 2d49f336998a1bdf71f30998b5019e142bd852eb Mon Sep 17 00:00:00 2001 From: Denis Smet Date: Tue, 13 Feb 2024 11:36:57 +0400 Subject: [PATCH 2/5] Refine GitHub action workflow and adjust test case --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 35b942a..3c2a668 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -64,7 +64,6 @@ jobs: input-file: ./target/coverage/junit.xml input-format: junit output-file: ./build/junit.xml - if: success() continue-on-error: true linters: From 0bb162d6631259866db53d80b21f3142fa440d8c Mon Sep 17 00:00:00 2001 From: Denis Smet Date: Tue, 13 Feb 2024 11:43:56 +0400 Subject: [PATCH 3/5] Refine GitHub action workflow and adjust test case --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 3c2a668..fc68e16 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -49,7 +49,7 @@ jobs: lein: 'latest' - name: 🧪 Generate coverage report - run: lein cloverage --coveralls --junit + run: lein cloverage --coveralls --junit || true - name: 🧪 Coveralls uses: coverallsapp/github-action@master From 9b537cfd6d3ddb00ccda14a9e9a43ab0326bd40a Mon Sep 17 00:00:00 2001 From: Denis Smet Date: Tue, 13 Feb 2024 11:46:09 +0400 Subject: [PATCH 4/5] Refine GitHub action workflow and adjust test case --- .github/workflows/main.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index fc68e16..6618602 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -49,7 +49,8 @@ jobs: lein: 'latest' - name: 🧪 Generate coverage report - run: lein cloverage --coveralls --junit || true + run: lein cloverage --coveralls --junit + continue-on-error: true - name: 🧪 Coveralls uses: coverallsapp/github-action@master @@ -64,7 +65,6 @@ jobs: input-file: ./target/coverage/junit.xml input-format: junit output-file: ./build/junit.xml - continue-on-error: true linters: name: Linters From b6916f3f1cac7ccbed369ab15b621e07b674abb0 Mon Sep 17 00:00:00 2001 From: Denis Smet Date: Tue, 13 Feb 2024 11:47:29 +0400 Subject: [PATCH 5/5] Refine GitHub action workflow and adjust test case --- .github/workflows/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6618602..3156ac2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -64,7 +64,6 @@ jobs: with: input-file: ./target/coverage/junit.xml input-format: junit - output-file: ./build/junit.xml linters: name: Linters