Properly qualify (prefix server endpoint URL + /) the request URI for logs

Author: GreemDev

src/Client/UpdateClient/UpdateClient.Admin.cs

@@ -18,7 +18,7 @@ public partial class UpdateClient
     {
         if (!_config.CanUseAdminEndpoints)
         {
-            Log("Cannot use {0} endpoint, as there is no configured admin access token.", [nameof(RefreshVersionCacheAsync)]);
+            Log("Cannot request cache refresh, as there is no configured admin access token.");
             return null;
         }
 

src/Client/UpdateClient/UpdateClient.Download.cs

@@ -28,7 +28,7 @@ public partial class UpdateClient
                   $"&rc={rc.AsQueryStringValue()}" +
                   $"&version={version}";
 
-        Log("Downloading the file from: {0}", [url]);
+        Log("Downloading the file from: {0}", [QualifyUriPath(url)]);
 
         var resp = await _http.GetAsync(url);
 

src/Client/UpdateClient/UpdateClient.Latest.cs

@@ -27,7 +27,7 @@ public partial class UpdateClient
                   $"&arch={arch.AsQueryStringValue()}" +
                   $"&rc={rc.AsQueryStringValue()}";
 
-        Log("Checking for updates from: {0}", [url]);
+        Log("Checking for updates from: {0}", [QualifyUriPath(url)]);
 
         var resp = await _http.GetAsync(url);
 

src/Client/UpdateClient/UpdateClient.cs

@@ -34,9 +34,11 @@ void IDisposable.Dispose()
         _http.Dispose();
         GC.SuppressFinalize(this);
     }
+
+    private string QualifyUriPath(string path) => $"{_config.ServerEndpoint.TrimEnd('/')}/{path}";
 
-    private void Log(string format, IEnumerable<object> args, [CallerMemberName] string caller = null!) 
-        => _config.Logger(format, args.ToArray(), caller);
+    private void Log(string format, IEnumerable<object>? args = null, [CallerMemberName] string caller = null!) 
+        => _config.Logger(format, args?.ToArray() ?? [], caller);
 
     private void ApplyAuthorization(HttpRequestMessage httpRequest)
     {