Skip to content

extractArrowValue: MAP keys are always stringified via fmt.Sprintf #260

@jghoman

Description

@jghoman

Summary

extractArrowValue in server/flight_executor.go returns map[string]interface{} for Arrow MAP arrays. All map keys are coerced to strings via fmt.Sprintf("%v", k), regardless of their actual Arrow type.

This works today because conn.go:formatMapValue accepts map[string]any and the PG text protocol is all strings anyway. But it means:

  • Key type information is lost (an int32 key 1 becomes the string "1")
  • Round-tripping MAP values back through DuckDB may produce incorrect types
  • Binary PG format support would need the original typed keys

Current behavior

// flight_executor.go extractArrowValue, MAP case
m[fmt.Sprintf("%v", k)] = v

A MAP(INTEGER, VARCHAR) with entries {1: "one", 2: "two"} becomes map[string]any{"1": "one", "2": "two"}.

Expected behavior

Preserve typed keys, e.g. return a []MapEntry{{Key: int32(1), Value: "one"}, ...} or similar ordered structure that retains:

  1. Original key types
  2. Insertion order (DuckDB MAPs are ordered)

Context

This was noted while fixing the STRUCT/MAP control-plane deserialization bug (STRUCT and MAP cases were missing entirely from extractArrowValue and arrowTypeToDuckDB). The string-key approach was chosen deliberately to match the existing formatMapValue(map[string]any) consumer in conn.go, but it's a known limitation.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions