`make check` fails for ocrd_cis

[stweil]

Here is the failing command:

% ocrd-cis-ocropy-binarize 2>&1|perl -pe s,/Users/stweil/src/github/OCR-D,,g
Traceback (most recent call last):
  File "/venv3.12_20250409/bin/ocrd-cis-ocropy-binarize", line 5, in <module>
    from ocrd_cis.ocropy.cli import ocrd_cis_ocropy_binarize
  File "/venv3.12_20250409/lib/python3.12/site-packages/ocrd_cis/ocropy/cli.py", line 4, in <module>
    from ocrd_cis.ocropy.binarize import OcropyBinarize
  File "/venv3.12_20250409/lib/python3.12/site-packages/ocrd_cis/ocropy/binarize.py", line 23, in <module>
    from . import common
  File "/venv3.12_20250409/lib/python3.12/site-packages/ocrd_cis/ocropy/common.py", line 14, in <module>
    from . import ocrolib
  File "/venv3.12_20250409/lib/python3.12/site-packages/ocrd_cis/ocropy/ocrolib/__init__.py", line 11, in <module>
    from . import default, common
  File "/venv3.12_20250409/lib/python3.12/site-packages/ocrd_cis/ocropy/ocrolib/common.py", line 32, in <module>
    from . import morph
  File "/venv3.12_20250409/lib/python3.12/site-packages/ocrd_cis/ocropy/ocrolib/morph.py", line 346, in <module>
    def all_neighbors(image, dist=1, bg=NaN):
                                        ^^^
NameError: name 'NaN' is not defined. Did you mean: 'nan'?

See also issue #458.

[bertsky]

That's not from any recent version of ocrd_all/ocrd_cis.

[stweil]

That's the very latest code. Output from git blame:

c2b50899 (Robert Sachunsky 2020-05-09 22:00:43 +0200 346) def all_neighbors(image, dist=1, bg=NaN):

Output from git status:

HEAD detached at db65d7f
nothing to commit, working tree clean

[bertsky]

Like I said – old version (from 2020!)

ocrd_all/master runs with https://github.com/cisocrgroup/ocrd_cis/tree/db65d7fbea89d9fe8055eddb302eeb6c7294159e
ocrd_cis/fix-alpha-shape runs with https://github.com/bertsky/ocrd_cis/tree/5cf22f5baa093ffaf0049e3c9756094116273598

[stweil]

Robert, lies bitte, was ich oben geschrieben habe! "HEAD detached at db65d7f" ist – wie du selbst schreibst – die aktuelle Version, und darin gibt es halt einen Commit von 2020, der jetzt bei mir zu einer Fehlermeldung führt.

[stweil]

https://github.com/cisocrgroup/ocrd_cis/blob/db65d7fbea89d9fe8055eddb302eeb6c7294159e/ocrd_cis/ocropy/ocrolib/morph.py#L346.

[stweil]

@kba, I suggest to reopen #458 because I think that fixing that issue would make the discussion and maintenance much easier.

[bertsky]

There was apparently a mistake in #456.

Will be fixed in #457

[kba]

Yeah, sorry about that, I messed up in #456, fix incoming.