[17.0] l10n_fr UniqueViolation account_report_expression_line_label_uniq tax_report_data.xml

[Lukwos]

Since this PR (odoo/odoo#203227), the account.report.expression are explicitely set and when I run the migration from 16.0 to 17.0, I get a contraint error :

psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "account_report_expression_line_label_uniq"
DETAIL:  Key (report_line_id, label)=(165, balance) already exists.

Module

l10n_fr

[remi-filament]

Thanks for reporting this @Lukwos I just faced the exact same issue.
They removed aggregation_formula which was using an inverse to compute expressions and replaced those by well defined expressions.

The problem is that these expressions did not have an XML-id and are therefore not updated but recreated instead leading to hitting unicity constraint.

Since these entries are not noupdate="1", it seems safe to remove them before Odoo will automatically recreate them properly.

The following SQL script does the job and should be added to l10n_fr migration scripts :

DELETE FROM account_report_expression 
WHERE label='balance' 
    AND report_line_id IN (
        SELECT res_id FROM ir_model_data
        WHERE module='l10n_fr'
        AND name in ('tax_report_16', 'tax_report_23', 'tax_report_TIC_total', 'tax_report_X4', 'tax_report_Y1', 'tax_report_Y2', 'tax_report_Y3', 'tax_report_Z4', 'tax_report_32')
        AND model='account.report.line')
    AND id NOT IN (
        SELECT res_id FROM ir_model_data WHERE module='l10n_fr' AND model='account.report.expression'
);