I have recently implemented cropping of rollout files, since global rollouts take up a lot of space and I am interested in only smaller regions downstream. Do you think this would be a useful feature to include in the main repo?
If so, what else do you think is needed for a PR? For example:
- should the cropping extend to bias?
easy to implement but not very useful since it’s O(1) not O(T) space as far as I can tell
- should the cropping extend to metrics?
that would actually be very nice but I think pretty hard to do relative to the current changes
- should the in-memory buffer be already cropped?
I tried to touch as little of the existing logic as possible with these changes, hence only cropping just before saving to disk
- how does this all interact with input cropping I’ve seen mentioned in metrics?
no idea, but likely in complicated ways
I have recently implemented cropping of rollout files, since global rollouts take up a lot of space and I am interested in only smaller regions downstream. Do you think this would be a useful feature to include in the main repo?
If so, what else do you think is needed for a PR? For example:
easy to implement but not very useful since it’s O(1) not O(T) space as far as I can tell
that would actually be very nice but I think pretty hard to do relative to the current changes
I tried to touch as little of the existing logic as possible with these changes, hence only cropping just before saving to disk
no idea, but likely in complicated ways