From 5848ec00e8c250377287c18eff57509b0a48dffc Mon Sep 17 00:00:00 2001 From: Michael Timbert Date: Tue, 24 Feb 2026 11:43:41 +0100 Subject: [PATCH 1/4] Add artifact build to the CI --- .github/workflows/ci.yml | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6000f412b..b8583ef99 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -97,3 +97,33 @@ jobs: - name: Test run: | prove -lv t + + build-artifact: + needs: run-tests + runs-on: ubuntu-22.04 + steps: + - uses: actions/checkout@v4 + + - name: apt install + run: sudo apt-get install -y build-essential git libmodule-install-perl + + - name: build + run: perl Makefile.PL && make dist + + - name: Get short SHA + id: short_sha + run: echo "short_sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT + + - name: Get Zonemaster-Engine version + id: version + run: | + result=`grep "use version; our $VERSION" lib/Zonemaster/Engine.pm` + result+='printf $VERSION;' + VERSION=`perl -e "$result"` + echo "version=$VERSION" >> $GITHUB_OUTPUT + + - name: upload artifact + uses: actions/upload-artifact@v4 + with: + name: Zonemaster-Engine-${{ steps.version.outputs.version }}-${{ steps.short_sha.outputs.short_sha }} + path: Zonemaster-Engine-${{ steps.version.outputs.version }}.tar.gz From b488e482ce405eba51e1fd49b3d0623b29723a0d Mon Sep 17 00:00:00 2001 From: Michael Timbert Date: Tue, 3 Mar 2026 08:18:46 +0100 Subject: [PATCH 2/4] fixing missing .mo files --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b8583ef99..403d79635 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -108,7 +108,7 @@ jobs: run: sudo apt-get install -y build-essential git libmodule-install-perl - name: build - run: perl Makefile.PL && make dist + run: perl Makefile.PL && make all dist - name: Get short SHA id: short_sha From bb55908e72770a543b7b19970c94be437afbd14f Mon Sep 17 00:00:00 2001 From: Michael Timbert Date: Tue, 3 Mar 2026 10:10:34 +0100 Subject: [PATCH 3/4] add gettext dependency --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 403d79635..c190ded72 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -105,7 +105,7 @@ jobs: - uses: actions/checkout@v4 - name: apt install - run: sudo apt-get install -y build-essential git libmodule-install-perl + run: sudo apt-get install -y build-essential git libmodule-install-perl gettext - name: build run: perl Makefile.PL && make all dist From 90e2ebe6e557b7716cbda147881a95f4be7d746e Mon Sep 17 00:00:00 2001 From: Michael Timbert Date: Tue, 3 Mar 2026 13:45:42 +0100 Subject: [PATCH 4/4] fix sha commit --- .github/workflows/ci.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c190ded72..5b08e553e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -112,7 +112,12 @@ jobs: - name: Get short SHA id: short_sha - run: echo "short_sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT + run: | + if [ "${{ github.event_name }}" == "pull_request" ]; then + echo "SHORT_SHA=$(echo ${{ github.event.pull_request.head.sha }} | cut -c1-7)" >> $GITHUB_ENV + else + echo "SHORT_SHA=$(echo ${{ github.sha }} | cut -c1-7)" >> $GITHUB_ENV + fi - name: Get Zonemaster-Engine version id: version @@ -125,5 +130,5 @@ jobs: - name: upload artifact uses: actions/upload-artifact@v4 with: - name: Zonemaster-Engine-${{ steps.version.outputs.version }}-${{ steps.short_sha.outputs.short_sha }} + name: Zonemaster-Engine-${{ steps.version.outputs.version }}-${{ env.SHORT_SHA }} path: Zonemaster-Engine-${{ steps.version.outputs.version }}.tar.gz