github pull-request "check-cla" still fails even though I have signed the CONTRIBUTORS.md file

[MichaelWhitall]

Hi folks,

How do I stop github from spamming my inbox incessantly about tests in my lfric_apps pull-request which apparently haven't passed, when there's no good reason for that? My offending pull request is this one: MetOffice/lfric_apps#292

a) The "check-cla" test (which checks that I've signed the Momentum contributors license before contributing) is stubbornly failing even though I have added my name to the CONTRIBUTORS.md file in my branch as instructed (and fixed conflicts in that file, and pushed it to my branch in my fork of the repo). Any idea how to make this test pass?

b) As-of today, I'm repeatedly getting messages that "Check CR approved" is failing. I think this is supposed to check whether code/system review has been approved. I don't expect it to be approved yet as its still under sci/tech review. Why is it repeatedly running this test prematurely and spamming me about code review not yet being approved?

Cheers!
Mike

[Andrew Clark (arjclark)]

At a guess could it be because you've signed the CLA as "michaelwhitall" and your username is "MichaelWhitall"?

[MichaelWhitall]

Awesome thanks yes that was it :) The usernames just above where I added mine were all lower-case so I assumed that was the expected format!

[James Bruten (james-bruten-mo)]

Hi Mike,

I think the cla checker is failing because it's case sensitive to your username - so MichaelWhitall in the first column should do it.

Yes, the check CR approved is a bit overzealous, but adds protection against the PR being merged prematurely (ie before kgos/macros have been updated at HoT). We have this as it's a lot easier to commit PRs in github than it was in fcm. We're trying to think of ways to keep that protection without it being quite so annoying!

[MichaelWhitall]

Thanks James, no prob :)

I think I started getting all the spam from CR approved checker after this event in my PR:
[mo-ssd-bot](https://github.com/mo-ssd-bot) moved this from SciTech Review to Changes Requested in [Simulation Systems Review Tracker](https://github.com/orgs/MetOffice/projects/376)
Any idea why the bot did this? My PR is very-much still under Sci/Tech review, so I didn't expect it to get moved to another state yet.

What would really help is if I can find a way to switch off email notifications about the CI tests / random things the bot does under the hood, but still get notifications when another human posts a comment on my PR. Any ideas how to do this? (I just tried asking github copilot but it seems to be hanging for ages without giving an answer!)

Cheers!
Mike

[MichaelWhitall]

PS copilot eventually came round again :) It looks like I can indeed switch off email notifications from "actions" / "workflow runs" here: https://github.com/settings/notifications
I'll try that :)

[Jenny Hickson (jennyhickson)]

Your PR was moved to Changes Requested because your scitech reviewer has left comments for you to deal with. Changes Requested state is for anything that requires the developer to look at it, rather than the reviewer. Once you're happy it is ready for them to look at again then press the circling arrows next to her name in the reviewers pane and the state will move back to Scitech again. This is the equivalent of switching the "owned by" on a trac ticket. Hope that helps.

Sadly I don't know the answer to getting the right level of emails from GitHub - they are persistent and many and I feel your pain!

[Yaswant Pradhan (yaswant)]

I think the cla checker is failing because it's case sensitive to your username - so MichaelWhitall in the first column should do it.

Yes, the check CR approved is a bit overzealous, but adds protection against the PR being merged prematurely (ie before kgos/macros have been updated at HoT). We have this as it's a lot easier to commit PRs in github than it was in fcm. We're trying to think of ways to keep that protection without it being quite so annoying!

Action: GitHub usernames should be treated as case-insensitive. We should fix this.

[Yaswant Pradhan (yaswant)]

Hi MichaelWhitall with the exception to case sensitive cla-check failure, all other features (cr_check and changes requested), you have reported here are functionally correct.

[MichaelWhitall]

Hi thanks Yaswant, yes i think its all fine now :) I don't mind about the cla-checker being case-sensitive; I just got confused because a bunch of other usernames in the contributors file happened not to have any capital letters in them and I naively tried to copy their format! The cr_check is also fine, now that I've figured out how to switch off email notifications from the CI testing :) I guess the one remaining minor niggle is that the PR template has a tick-box for:

All automated checks in the CI pipeline have completed successfully

Presumably this is redundant, since noone can correctly tick this box until the cr_check in CI passes, and this won't happen until code-review is already complete!

Cheers,
Mike