Code Owner Approvals in LFRic Apps

[Jenny Hickson (jennyhickson)]

Hello

We've now added a full Code Owners file to LFRic Apps. This will trigger GitHub to request reviews from the code owners of files changed as part of a pull request, allowing these key people to help steer our development.

What does this mean for me?

Developer:

• While the requests for code owner approval will be made automatically when a pull request is open, you don't need to wait for this. The list of names can be viewed at any time in .github/CODEOWNERS and engaging with the key code owners for the areas you are working in early is always recommended to gain their insight and perspectives.
• If a code owner is away and hasn't looked at a pull request then you are welcome to look up who the deputy is in the above file and ask them to look instead.
• Respond to code owner reviews as you would SciTech or Code Reviews

Code Owners:

• Look at Pull Requests that have requested your review. Unless you are also the SciTech or Code reviewer then you only need to check the files in your area.
• If you are happy with the changes then leave a review that "approves" (leaving a comment with it or not as you like) - this makes it clear that you've checked the change.
• If you'd like to request changes then you can use the usual review process.
• Pull requests will not wait indefinitely for all code owners to approve. If you'd like to look at a pull request but need more time then leave a comment so that the code reviewer is aware that your review is coming.

Code Reviewers:

• Don't approve a change while there are outstanding conversations happening with code owners.
• Leave a reasonable time for code owners to look at a pull request - this is deliberately vague, as what is reasonable will depend on the size and complexity of the change. As a guide - a larger change should give at least a week from the pull request being opened to approval and merging to allow for code owners who may be on leave to look at it.

Many Thanks
Jenny