Skip to content

CMake add_jana_plugin() uses wrong default for LIBRARY_EXPORT #488

@nathanwbrei

Description

@nathanwbrei

Defaults to "jana2_targets" instead of not exporting. Raiqa raises the question "why export plugins at all? Makes sense for add_jana_libraries(), but not add_jana_plugins()", to which I answer "because historically we linked against plugins as if they were mere libraries, and in some places we might still be, even though that's not the recommended practice anymore". If it's the recommended practice, we should do it consistently within the JANA2 codebase

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions