Skip to content

build(hooks): hashicorp copyright pre-commit hooks takes to much time #696

@danielelotito

Description

@danielelotito

Add copyright headers pre-commit hook from https://github.com/hashicorp/copywrite takes between 1.5 and 3.2 minutes on my machine. Plus sometimes it fails even when it should not.

To (try to) reproduce the issue, clone ado and

uv sync --python=3.12

Then do a commit

example of commit error when the hook failed with no legit reason

> git -c user.useConfigOnly=true commit --quiet --allow-empty-message --file -
Detect secrets...........................................................Passed
ruff (legacy alias)..................................(no files to check)Skipped
black-jupyter........................................(no files to check)Skipped
codespell................................................................Passed
uv-lock..............................................(no files to check)Skipped
uv-export............................................(no files to check)Skipped
Add copyright headers....................................................Failed
- hook id: add-headers
- files were modified by this hook

Using license identifier: MIT
Using copyright holder: IBM Corporation

[1mExempting the following search patterns:[0m
[36m.cra/**[0m
[36m.eggs/**[0m
[36m.git/**[0m
[36m.github/**[0m
[36m.idea/**[0m
[36m.pre-commit-config.yaml[0m
[36m.tox/**[0m
[36m.venv/**[0m
[36m.vscode/**[0m
[36m**build/lib/**[0m
[36mdist/**[0m
[36mtoxenv/**[0m

[1mUpdating existing copyright headers:[0m
[1mAdding missing copyright headers:[0m

markdownlint-cli2........................................................Passed
yamlfmt..............................................(no files to check)Skipped
tombi-format.........................................(no files to check)Skipped

Details

I have opened hashicorp/copywrite#211

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciEnables CI integration

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions