First row not sorted when no header

[cyrille-gachot]

Hi,

I'm using your plugin to sort entries from the todo plugin list.

Here is an example of the text I have

<sortable 1 1=alpha sumrow=0>
~~TODOLIST checkbox:no header:none~~
</sortable>

The problem I see is that when there is no header, the first line of the table is never sorted.

I looked at the code, and tried to change the following lines

        var havetHead = table.tHead;
        var sindex = 1;
        if ( havetHead ) {
            sindex = 0;
        }

to

        var havetHead = table.tHead;
        var sindex = 0;
        if ( havetHead ) {
            sindex = 1;
        }

So i basically switched the values 0 and 1 for the start index. It fixed the bug for me, but I'm not really sure of the global impact this might have, which is why I've not pushed an PR.

[FyiurAmron]

@cyrille-gachot are you using https://www.dokuwiki.org/plugin:todo ? Generally speaking, cross-plugin compatibility is outside of scope of this project, since it's as a rule of thumb it's impossible to synchronize the idiosyncrasies of them. I'll take a look at this though, it seems strange enough to warrant some investigation.

[FyiurAmron]

OK, I was able to replicate. You're right, current code wrongly assumes that with no header row, the 1st row is the header and shouldn't be sorted. I guess it's possible that it was intentional, but it's still wrong in my opinion. I'll try to find a stable fix ASAP.

Also, plugin:todo is throwing PHP warnings like crazy (at least on my box, mostly Warning: Undefined array key and Warning: Undefined variable) - you might want to report that to them also.

[FyiurAmron]

@cyrille-gachot sadly, what you propose as a fix wouldn't work by itself with current code - you can test it yourself, in headerless tables it requires you to click the former "first" row to reverse the sorting, i.e. with table originally made of rows T3 T1 T2, you'd get sorted T1 T2 T3, but to reverse-sort it, you'd need to click on T3 now. I'm working on a proper fix though.