Skip to content

fix: use SI decimal file size units#306

Merged
naveensingh merged 2 commits intomainfrom
naveensingh/fix-size-calc
Feb 8, 2026
Merged

fix: use SI decimal file size units#306
naveensingh merged 2 commits intomainfrom
naveensingh/fix-size-calc

Conversation

@naveensingh
Copy link
Member

@naveensingh naveensingh commented Feb 8, 2026

Type of change(s)

  • Bug fix
  • Feature / enhancement
  • Infrastructure / tooling (CI, build, deps, tests)
  • Documentation

What changed and why

Updated formatSize() helpers to divide by 1000 instead of 1024.

Tests performed

  • Confirmed file size in all apps that rely on formatSize()

Closes the following issue(s)

Checklist

  • I read the contribution guidelines.
  • I manually tested my changes on device/emulator (if applicable).
  • I updated the "Unreleased" section in CHANGELOG.md (if applicable).
  • I have self-reviewed my pull request (no typos, formatting errors, etc.).
  • All checks are passing.

@naveensingh naveensingh marked this pull request as ready for review February 8, 2026 11:26
@naveensingh naveensingh merged commit 4373d1c into main Feb 8, 2026
7 checks passed
@naveensingh naveensingh deleted the naveensingh/fix-size-calc branch February 8, 2026 11:33
@roxwize
Copy link

roxwize commented Mar 18, 2026

I can't say I'm fond of this change. A way to revert back to standard 1,024 divisors for file size would be nice. My file manager does it this way and having there now be an obvious discrepancy in the representation of filesizes between the two is troublesome.

I never really understood using SI prefixes anyways? Computers work in powers of two, there isn't really a benefit I can think of to representing them in a way that, in binary, uses a totally arbitrary number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to display file/storage sizes in decimal base

2 participants