Merged
Conversation
|
I can't say I'm fond of this change. A way to revert back to standard 1,024 divisors for file size would be nice. My file manager does it this way and having there now be an obvious discrepancy in the representation of filesizes between the two is troublesome. I never really understood using SI prefixes anyways? Computers work in powers of two, there isn't really a benefit I can think of to representing them in a way that, in binary, uses a totally arbitrary number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change(s)
What changed and why
Updated
formatSize()helpers to divide by 1000 instead of 1024.Tests performed
formatSize()Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).