Improve Onyx PRs reviewing process

[fabioh8010]

We are often seeing PRs being merged into Onyx that are not following adequate security and quality practices. The changes are sometimes "innocent" but if we don't maintain a high quality bar of the codebase they can will out of control, we will lose coverage and that's where the tricky bugs start happening. Here are some examples:

• fix: result isn't changed when the member collection change react-native-onyx#708 - looks like a low-quality solution and there are no unit tests whatsoever
• fix: Send collection key as matchedKey in collection callbacks react-native-onyx#720 - checklist empty, unit tests added but no manual testing
• fix: result isn't changed when the member collection change v2 react-native-onyx#716 - follow up of the “low-quality” PR, no unit tests added/changed
• fix: onyx snapshot cache & status react-native-onyx#711 - new logic but no tests added
• fix: status is infinity loading for the none-exist key react-native-onyx#709 - no tests added/changed

I would say that all PRs in Onyx must have manual, automated tests and videos unless specifically written and approved why they don't/can't have.

Let's think into ways to improve this process and not let bugs/uncovered code be shipped into such critical library that is Onyx.

Issue Owner

Current Issue Owner: @fabioh8010

[melvin-bot]

This issue has not been updated in over 15 days. @fabioh8010, @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

Havent prioritized this yet, but @fabioh8010 feel free to create PRs for the actions that will require the automated tests

[MrMuzyk]

Hey, I'll take over this one from @fabioh8010 :)

[MrMuzyk]

I've opened a draft PR and will continue tomorrow.

@mountiny I've added a descirption in the PR describing what I've done so far. I've talked with @fabioh8010 on what was discussed before and went in this direction. Let me know if there is something else you'd like to have for sure.

One thing I've considered is having an escape hatch mechanism that would allow us skipping the tests if really really necessary. We can punt it right now if you don't think it's needed.