Disable Migrate Wallets when no assets to migrate#5984
Merged
Conversation
Address pre-existing strict-boolean-expressions and use-unknown-in-catch-callback-variable violations exposed by ESLint warning graduation.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
Author
|
Both nits addressed: renamed |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Move the migrate-wallet eligibility logic from MigrateWalletSelectCryptoScene into a shared utility so it can be reused in SettingsScene and WalletActions.
j0ntz
force-pushed
the
jon/fix/disable-empty-migrate
branch
from
990ff18 to
18a3c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Asana task
Disable the "Migrate Wallets" button in Settings when there are no assets available to migrate, matching the existing "Restore Wallets" disabled pattern. Also filter compromised-key wallet IDs through the same eligibility check so the migrate modal is never shown for wallets with no migratable assets.
Extracts the migrate-wallet eligibility logic into a shared
getMigrateWalletItemListutility to avoid duplicating the filtering rules across SettingsScene, WalletActions, and MigrateWalletSelectCryptoScene.Closes https://app.asana.com/1/9976422036640/project/1200972350208303/task/1211114363135206
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Moderate risk because it changes eligibility logic that gates the wallet migration flow and affects compromised-key handling/navigation; mistakes could incorrectly hide migration or preselect wrong wallets.
Overview
Disables the Settings
Migrate Walletsrow when there are no eligible non-zero assets to migrate, matching the existing disabled behavior forRestore Wallets.Extracts and centralizes migration eligibility into
getMigrateWalletItemList, and updates migration-related scenes/actions to use a singlecreateWalletIdfield (instead of an array) and to only show the compromised-key migration modal / preselect wallets that actually have migratable assets.Written by Cursor Bugbot for commit 18a3c1b. This will update automatically on new commits. Configure here.