BungeeCord API on classpath in VentureChat .jar #152
Description
net.md_5.bungee is on the VentureChat's classpath, i.e. the package and its subpackages/classes are in the shipped VentureChat .jar file.
It's bad practice to ship your runtime dependencies in your own jar, because it might lead to unwanted behavior (when running on BungeeCord you will now use your own version of the BungeeCord API, which might clash with the one BungeeCord actually uses). But this issue also makes it so the classes are on the classpath on any other platform, such as spigot/paper.
This made it such that a plugin I'm working on doesn't work on another server, because it detected its environment as being BungeeCord. The way I check for this is if BungeeCord's API is present. Because VentureChat ships this, the BungeeCord API is also present on Spigot/Paper, causing a crash in my plugin.
It's an easy enough fix on my end, but this will cause VentureChat to be incompatible with other plugins that perform similar checks. Please fix this so your plugin stays compatible with other plugins!
Tl;dr, please change the scope of your bungeecord api dependency to provided instead of compile in pom.xml. I also see there are two definitions of different bungeecord-api versions... Might be something worth checking.