-
-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Summary
Navigation currently has fewer CI workflows and lower test coverage compared to sibling repos (AppState, Later, Fork, Cache).
Current State
- CI workflows: Only
docc.ymlandmacOS.yml— missingubuntu.ymlandwindows.ymlthat are present in most other 0xLeif packages - Test coverage: Only 1 test file (
NavigationTests.swift) covering 3 source files (Navigator.swift,NavigatorButton.swift,Navigation.swift) - CI triggers: macOS workflow only triggers on push, not on pull requests
Suggested Improvements
- Add
ubuntu.ymlworkflow — modeled after the equivalent workflow in AppState/Later/Fork/Cache - Add
windows.ymlworkflow — same as above - Add
pull_requesttrigger to the macOS workflow - Upgrade
actions/checkout@v3tov4in existing workflows - Expand test coverage — add dedicated tests for
NavigatorandNavigatorButtonfunctionality
Priority
Test coverage expansion is the highest impact improvement here. The missing CI platforms are lower priority but would bring Navigation in line with the other packages.
🤖 Filed by corvid-agent during autonomous improvement pass
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels